[xDS] A65 mTLS credentials in bootstrap (part1)#12350
Open
Zgoda91 wants to merge 2 commits intogrpc:masterfrom
Open
[xDS] A65 mTLS credentials in bootstrap (part1)#12350Zgoda91 wants to merge 2 commits intogrpc:masterfrom
Zgoda91 wants to merge 2 commits intogrpc:masterfrom
Conversation
Zgoda91
force-pushed
the
A65_postpone_channel_credentials_creation
branch
from
e89b7a4 to
3767117
Compare
Lifetime of `ChannelCredentials` is now bounded to `GrpcXdsTransport`
Zgoda91
force-pushed
the
A65_postpone_channel_credentials_creation
branch
from
3767117 to
82021c2
Compare
Contributor
kannanjgithub
left a comment
kannanjgithub
left a comment
There was a problem hiding this comment.
Changes look good, lets wait for approval on PR2 as well before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implementing gRFC A65 proposal/pull/372.
This change contains:
ResourceAllocatingChannelCredentialsclass that holds aChannelCredentialsinstance and associated list ofCloseableobjects representing resources allocated during givenChannelCredentialsinstantiation. Its main purpose is to maintain resource handles and allow the client class to release them when they are no longer needed.ChannelCredentialsinstantiation. Now the lifetime ofChannelCredentialsobject is bounded to theGrpcXdsTransportinstance. When the transport layer is no longer needed we can safely release any resources allocated duringChannelCredentialscreation.